feat: npm install -g ttyper #97
Conversation
|
Hey @max-niederman, could you please review when you're available? |
There was a problem hiding this comment.
First off, I just want to apologize for letting this go unreviewed for so long. I've been really busy lately with college applications and some health issues, but I should now have more time to maintain ttyper.
Anyway, I think there's some issue with this implementation. When I install the npm package and try to run ttyper, I get the following error:
As a minimal reproduction, you can get this error by starting an Alpine linux container, installing the npm package, then running npm install -g ttyper and ttyper. I'm not sure why this happens, exactly, but I suspect this is because it copies the runner file into /usr/local/bin, so trying to get the binary using a path relative to the runner script fails.
|
Hi @max-niederman. Welcome back. I'll take a look. |
| "repository": { | ||
| "type": "git", | ||
| "url": "git+https://github.com/Anush008/ttyper.git" | ||
| }, | ||
| "releasesUrl": "https://github.com/Anush008/ttyper/releases", |
There was a problem hiding this comment.
TODO: Update these URLs to https://github.com/max-niederman/ttyper
|
Hi @max-niederman. Could you try |
This PR intends to add
npm install -g ttyperas an installation strategy for Ttyper. Since NPM is the most used package manager, this would be a valuable addition to the project.https://www.npmjs.com/package/ttyper
Here's how this works:
When
npm installis run, NPM executes the install script, i.e.install.js.The
install.jsfile:bindirectory.node_moduleswith the tar and zip libraries, as they are not needed any further.ttyper, to whatever is set as thebinvalue in thepackage.json.binto runrunner.js, which handles the running of our downloaded binary.The added
npm-releaseAction job:package.jsonto be in parity with the release version.README.mdfrom the root dir to be displayed on the package's homepage.We can commit the version bump if we need to, but that would be an extra commit.
A successful run of this workflow can be found here.
@max-niederman, I'll move the NPM package to you and you can configure the
NPM_ACCESS_TOKENsecret for this repository.